[libcxx-commits] [PATCH] D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added subscribers: libc++ vendors, philnik.
philnik added a comment.

In D158011#4589757 <https://reviews.llvm.org/D158011#4589757>, @saugustine wrote:

> What exactly do you recommend here? The situation is pretty messy.
>
> Today the macro only guards them for target architecture, so they are enabled for Darwin on x86 today, but not Darwin on aarch64. That is true for every single OS that runs on (one of x86, x86_64, and powerpc) and anything else.
>
> So the same problems that exist for Darwin also exist for Fuschia and FreeBSD and many others.
>
> Perhaps a top-level CMake option would be best.

I think this is actually required on Darwin, since Apple used to ship libstdc++ on x86 at some point in the past. A CMake option seems to me like the sensible solution. Adding libc++ vendors, since they might have some insight here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158011/new/

https://reviews.llvm.org/D158011