[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added inline comments.


================
Comment at: libcxx/utils/ci/vendor/android/Dockerfile.emulator.base:22
+
+RUN curl -sL https://dl.google.com/android/repository/commandlinetools-linux-9477386_latest.zip -o cmdline-tools.zip && \
+    mkdir -p ${ANDROID_HOME} && \
----------------
ldionne wrote:
> Can we use a URL that points to the latest version so that we get a new version of the command-line tools when we rebuild that docker image?
> 
> Or do we want to be intentional about the version we're using here so that we only bump it when we really want to? If so, what is going to be the process for bumping it up? Is that something that you or other Android folks can commit to doing on a regular basis? Otherwise, this will be forgotten forever and will never be updated.
> Can we use a URL that points to the latest version so that we get a new version of the command-line tools when we rebuild that docker image?

I asked about this in a Google-internal discussion group but haven't heard anything yet. It doesn't look possible at the moment, unless we want to download an XML file and parse it to find the latest stable commandlinetools package.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147