[libcxx-commits] [PATCH] D156283: MIPS: unwind, don't save/restore hi/lo for R6

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 15 18:04:57 PDT 2023


MaskRay added a comment.

In D156283#4590529 <https://reviews.llvm.org/D156283#4590529>, @wzssyqa wrote:

> In D156283#4589972 <https://reviews.llvm.org/D156283#4589972>, @MaskRay wrote:
>
>>> wzssyqa removed a reviewer: libunwind.
>>
>> Some projects like libc++/libc++abi/libunwind add a default reviewer group. This ensures #libunwind <https://reviews.llvm.org/tag/libunwind/> people know changes going into libunwind. They may not comment, but they can do so when a change increasing maintenance burden catches their eye.
>
> I added libunwind group back.
> It was "blocking libunwind" previous. I have no idea what it means?

Someone in the #libunwind <https://reviews.llvm.org/tag/libunwind/> needs to click `Accept as libunwind` to make the differential green, otherwise it is in the `Needs Review` state even if there is an approval.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156283/new/

https://reviews.llvm.org/D156283



More information about the libcxx-commits mailing list