[libcxx-commits] [PATCH] D155330: [libc++][PSTL] Implement std::move
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 15 14:52:18 PDT 2023
philnik added inline comments.
================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.move/pstl.exception_handling.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
ldionne wrote:
> You need to add a test that `__move` is `noexcept`, we said we would add such tests in the PSTL / exception safety patch.
I thought we didn't need the test after all, since `noexcept` isn't necessary on the backend anymore and the death tests caught missing `noexcepts` quite well (and a std tests seems generally preferable to libc++-specific ones).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155330/new/
https://reviews.llvm.org/D155330
More information about the libcxx-commits
mailing list