[libcxx-commits] [PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

[Paul Scoropan via Phabricator via libcxx-commits]

pscoro added inline comments.


================
Comment at: flang/lib/Decimal/CMakeLists.txt:52
 
-add_flang_library(FortranDecimal INSTALL_WITH_TOOLCHAIN
-  binary-to-decimal.cpp
-  decimal-to-binary.cpp
-)
+add_compile_options(-fPIC)
+
----------------
efriedma wrote:
> This `add_compile_options(-fPIC)` shouldn't be necessary?
Pretty sure you're right, let me build/test without it to make sure and I'll update if everything is alright


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154869/new/

https://reviews.llvm.org/D154869