[libcxx-commits] [PATCH] D157778: [libc++][chrono] Fixes FreeBSD tests.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D157778#4582174 <https://reviews.llvm.org/D157778#4582174>, @dim wrote:

> In D157778#4582161 <https://reviews.llvm.org/D157778#4582161>, @emaste wrote:
>
>> I'm a bit surprised by `avr.` vs `avril` - it appears we allow up to 5 chars (`janv.`, `févr.` etc.) so it would seem `avril` is preferable to `avr.`. In any case of course these libc++ tests should match what FreeBSD does.
>
> This comes from https://github.com/freebsd/freebsd-src/blob/main/share/timedef/fr_FR.UTF-8.src#L10, and that in turn comes from https://github.com/unicode-org/cldr/blob/release-43-1/common/main/fr.xml#L2812 where the FreeBSD sources the Unicode stuff from. So it's probably just a quirk. The CLDR project has had "avr." as abbreviation since the original `fr.xml` was committed in 2003.

Thanks for the reviews! I indeed just match the tests with reality ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157778/new/

https://reviews.llvm.org/D157778