[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 14 12:12:41 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/header_information.py:61
+header_include_requirements = {
+    ("_LIBCPP_HAS_NO_ATOMIC_HEADER",): (
+        # headers with #error directives
----------------
iana wrote:
> The module map requires and `lit_header_restrictions` looked like there were going to be headers that had multiple requirements, which is why the key is requirement tuples. But it turned out that all the headers only have one requirement. Should I keep the tuple keys and support for multiples in the script, or just make the keys strings?
My preference would be to reinstate something like what we had before https://reviews.llvm.org/D151893.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364



More information about the libcxx-commits mailing list