[libcxx-commits] [PATCH] D155330: [libc++][PSTL] Implement std::move

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/pstl_move.h:22
+#include <__type_traits/is_trivially_copyable.h>
+#include <__type_traits/remove_cvref.h>
+
----------------
Missing `<optional>` include.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.move/pstl.exception_handling.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
You need to add a test that `__move` is `noexcept`, we said we would add such tests in the PSTL / exception safety patch.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.move/pstl.exception_handling.pass.cpp:22-26
+struct ThrowOnCompare {};
+
+#ifndef TEST_HAS_NO_EXCEPTIONS
+bool operator==(ThrowOnCompare, ThrowOnCompare) { throw int{}; }
+#endif
----------------
This is never used.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.move/pstl.move.pass.cpp:82-85
+struct TestIteratorsNonTrivial {
+  template <class Iter2>
+  void operator()() {}
+};
----------------
This is never used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155330/new/

https://reviews.llvm.org/D155330