[libcxx-commits] [PATCH] D155330: [libc++][PSTL] Implement std::move

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/pstl_move.h:32
+
+// TODO: Use the std::copy/move shenanigans to forward to std::memmove
+
----------------



================
Comment at: libcxx/include/__algorithm/pstl_move.h:43
+_LIBCPP_HIDE_FROM_ABI _ForwardOutIterator
+move(_ExecutionPolicy&& __policy, _ForwardIterator __first, _ForwardIterator __last, _ForwardOutIterator __result) {
+  return std::__pstl_frontend_dispatch(
----------------
This needs to be updated for exception safety, including tests.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/pstl.copy.pass.cpp:11
 
-// REQUIRES: with-pstl
 
----------------
You have two tests that still use `// REQUIRES: with-pstl`, which means they are always disabled. Please fix in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155330/new/

https://reviews.llvm.org/D155330