[libcxx-commits] [PATCH] D156225: [libcxx] <experimental/simd> Add broadcast constructor of class simd/simd_mask

Mon Aug 14 07:52:46 PDT 2023

philnik added a comment.

In D156225#4584167 <https://reviews.llvm.org/D156225#4584167>, @Joy12138 wrote:

> It seems `is_integral` not working correctly with `int128` and `unsigned int128`. https://godbolt.org/z/c4E5T7zc9
>
> I add specializations for `__can_broadcast` with `int128` and `unsigned int128`. It may fix tests now. Is it OK? Or should we fix `is_integral`?

`is_integral` is fine: https://godbolt.org/z/bdof3Krvo. It also looks like your change didn't actually fix the problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156225/new/

https://reviews.llvm.org/D156225