[libcxx-commits] [PATCH] D157625: [libc++][modules] Simplifies module testing.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 11:50:35 PDT 2023


Mordante created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
Mordante updated this revision to Diff 549252.
Mordante added a comment.
Mordante updated this revision to Diff 549402.
Mordante updated this revision to Diff 549429.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Fix CI.


Mordante added a comment.

CI fixes.


Mordante added a comment.

CI fixes.


The building of the std module has been moved from `params.py` and
`dsl.py` to a `lit.local.cfg` for the entire test suite. In theory this
change allows testing modules in most configurations, except:

- combined with clang modules
- C++ versions that don't support the std module

Currently only C++23 with all parts enabled works.
C++26 is expected to work properly with CMake 3.27. That versions of CMake
knows how to invoke clang using C++26.
The parts disabled modi of libc++ have not been modularized yet.

It still is the goal that in the future CMake will be able to do the work
done in `lit.local.cfg`. Doing this in CMake would require a more mature
libc++ implementation.

Thanks a lot to @ldionne for giving hints how to enable modules in a
`lit.local.cfg`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157625

Files:
  libcxx/CMakeLists.txt
  libcxx/cmake/caches/Generic-module-std-cxx23.cmake
  libcxx/include/__config_site.in
  libcxx/test/libcxx/module_std.gen.py
  libcxx/test/libcxx/modules_include.gen.py
  libcxx/test/lit.local.cfg
  libcxx/test/std/modules/std.pass.cpp
  libcxx/utils/libcxx/test/dsl.py
  libcxx/utils/libcxx/test/features.py
  libcxx/utils/libcxx/test/params.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157625.549429.patch
Type: text/x-patch
Size: 10066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230811/7a50692d/attachment.bin>


More information about the libcxx-commits mailing list