[libcxx-commits] [PATCH] D155258: [libc++] Granulaize math.h and move the functions to std::__math

[Sean via Phabricator via libcxx-commits]

SeanP added inline comments.


================
Comment at: libcxx/include/__math/abs.h:22
+
+namespace __math {
+
----------------
zibi wrote:
> @philnik Sorry for the late comment but we just noticed that our build is broken with this commit. 
> 
> We do run into name collision with `__math` being a header guard macro defined into one of our internal headers. Can it be change to have a different name, say __math_impl or something like that? 
> @philnik Sorry for the late comment but we just noticed that our build is broken with this commit. 
> 
> We do run into name collision with `__math` being a header guard macro defined into one of our internal headers. Can it be change to have a different name, say __math_impl or something like that? 

To clarify it isn't an internal header but the system math.h header.  The z/OS system headers tend to use macros like `__math` or `__stdio` for the file guard macros.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155258/new/

https://reviews.llvm.org/D155258