[libcxx-commits] [PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: libc++.
Mordante added a comment.

I only looked at the libc++ changes. The libc++ AIX CI failures are unrelated to your patch. LGTM modulo one nit.



================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/ctor.pair_U_V_move.pass.cpp:134
+         */
+        //test_pair_rv<ExplicitTypes::CopyOnly, ExplicitTypes::CopyOnly, true, false>();
+        static_assert(std::is_constructible<std::pair<ExplicitTypes::CopyOnly, int>,
----------------
Please remove this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156032/new/

https://reviews.llvm.org/D156032