[libcxx-commits] [PATCH] D157298: [RFC][libc++] Reduce the size of translation units

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 04:25:14 PDT 2023


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

I think guarded includes is a really bad idea. I think it's inviting us to create include cycles that are only present in certain dialects & configurationsn.
I would much rather pay the size increase than do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157298/new/

https://reviews.llvm.org/D157298



More information about the libcxx-commits mailing list