[libcxx-commits] [PATCH] D153408: [libc++][CI] Test std module in C++26 mode.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:211
 
+  - label: "C++23 Module std"
+    command: "libcxx/utils/ci/run-buildbot generic-module-std-cxx23"
----------------
Mordante wrote:
> ldionne wrote:
> > I am kinda worried about the explosion of the number of jobs. Is there a reason why we want to keep testing the std module in C++23? For example, we don't do that for Clang modules. We only test the latest standard version with Clang modules.
> Yes and No. C++26 adds new named declarations not available in C++23. For example there are already 3 new headers accepted for C++26; `hazard_pointer`, `rcu` and `text_encoding`. So we need to test C++26 and C++23 separately. Based on our discussion regarding testing modules yesterday we may want to take a different approach for testing modules.
> We can always build with modules enabled and run the `std` and `std.compat` module test separately in the Generic C++23/26 builds. For now I put this patch on hold; let's see what our testing strategy will be first.
I know have a different approach where I reuse the existing job to build the module tests. So instead of adding a new job it adds a few tests to the existing job. This also solves the scalability for testing with different libc++ configurations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153408/new/

https://reviews.llvm.org/D153408