[libcxx-commits] [PATCH] D157058: [libc++] Remove generic char_traits implementation

[Dmitri Gribenko via Phabricator via libcxx-commits]

gribozavr2 added inline comments.


================
Comment at: libcxx/include/__string/char_traits.h:79
-template <class _CharT>
-struct _LIBCPP_DEPRECATED_("char_traits<T> for T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 18, so please migrate off of it.")
-    char_traits
----------------
philnik wrote:
> mstorsjo wrote:
> > FWIW, I've never seen this deprecation message in earlier builds of lldb - I rechecked old build logs, and this wasn't ever printed.
> Do you have `-Wno-deprecated` or something like that in the config? I don't know what we can do other than deprecating the things we want to remove and mentioning them in the release notes.
This specialization is not used directly in LLDB's code. Thus the primary source location for the deprecation warning would be in another libc++ headers. Clang silences warnings in system headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157058/new/

https://reviews.llvm.org/D157058