[libcxx-commits] [PATCH] D157058: [libc++] Remove generic char_traits implementation

[Dmitri Gribenko via Phabricator via libcxx-commits]

gribozavr2 added a comment.

In addition to breaking LLDB's build itself, this change also broke the following test: https://github.com/llvm/llvm-project/blob/main/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/main.cpp that uses `std::basic_string<unsigned char>` - is it not allowed?

  Error when building test subject.
  
  [...]
  
  Build Command Output:
  [...]
  In file included from [...]/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/main.cpp:2:
  [...]/include/c++/v1/string:723:46: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
    723 |     static_assert(( is_same<_CharT, typename traits_type::char_type>::value),
        |                                              ^
  [...]/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/main.cpp:95:36: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here
     95 |   std::basic_string<unsigned char> uchar_source(10, 'a');
        |                                    ^
  [...]/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157058/new/

https://reviews.llvm.org/D157058