[libcxx-commits] [PATCH] D157060: [libc++] Fix problems with GCC 13 and switch to it in the CI

Wed Aug 9 15:16:23 PDT 2023

philnik added inline comments.

================
Comment at: libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:121
+// This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110904
+#ifndef TEST_COMPILER_GCC
     static_assert((!std::is_convertible<ConstFunction, Function*>::value), "");
----------------
Mordante wrote:
> philnik wrote:
> > Mordante wrote:
> > > All versions of GCC or just 13?
> > Just GCC 13
> Maybe add that information in the comment and in the header too. something like
> `TODO Enable again when https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110904 is fixed. The bug was introduced in GCC 13`.
It's already fixed in the GCC trunk. I've just made this an LLVM 19 TODO, since we will probably switch to GCC 14 then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157060/new/

https://reviews.llvm.org/D157060