[libcxx-commits] [PATCH] D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`.

Hristo Hristov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 9 14:52:07 PDT 2023


H-G-Hristov added a comment.

In D156924#4573070 <https://reviews.llvm.org/D156924#4573070>, @hawkinsw wrote:

> @H-G-Hristov Thank you for all the contributions -- your code was immensely helpful. I think that I am making some progress! If you have any thoughts on the way that things are going with the implementation, please let me know! Thanks again!

I'm also a rookie at this, so treat anything with a pinch of salt. This is may WIP patch for `enumerate_view`: https://reviews.llvm.org/D157193 I think it has some similarities to `stride_view`. It's missing a few converting constructor tests but after rebase it should get green. I do expect that it will get a lot of scrutiny and feedback in the review but I think you can check it for what tests you need to write. I've based my tests on already existing tests.

I am also going to update the status page with my patch soon: https://libcxx.llvm.org/Status/Ranges.html If you like I could update it for you too. Or you can do it yourself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156924/new/

https://reviews.llvm.org/D156924



More information about the libcxx-commits mailing list