[libcxx-commits] [PATCH] D156741: [IR] Remove no longer used methods for getting typed pointer types

[Nikita Popov via Phabricator via libcxx-commits]

nikic added a comment.

In D156741#4574536 <https://reviews.llvm.org/D156741#4574536>, @bjope wrote:

> Any concerns about removing these helpers from Type?   (@nikic I know you marked some other old API:s as deprecated rather than removing them directly, when dropping support for typed pointers. But I'm not sure if we need a deprecation period for this?)

For typed pointer APIs I would usually go for deprecation, because some of them were quite widely used. I guess if you didn't need to remove many uses in preparation for this patch, then dropping them directly is fine.



================
Comment at: libcxxabi/test/test_demangle.pass.cpp:22532
-    {"_ZN4llvm4Type13getInt32PtrTyERNS_11LLVMContextEj", "llvm::Type::getInt32PtrTy(llvm::LLVMContext&, unsigned int)"},
-    {"_ZN4llvm4Type13getInt64PtrTyERNS_11LLVMContextEj", "llvm::Type::getInt64PtrTy(llvm::LLVMContext&, unsigned int)"},
     {"_ZN4llvm12FunctionType17isValidReturnTypeEPKNS_4TypeE", "llvm::FunctionType::isValidReturnType(llvm::Type const*)"},
----------------
This test should not be modified. (It has no relation to LLVM; just uses our symbol names.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156741/new/

https://reviews.llvm.org/D156741