[libcxx-commits] [PATCH] D157060: [libc++] Fix problems with GCC 13 and switch to it in the CI

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general happy, but I would like to have a short look after my comment has been addressed.



================
Comment at: libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:121
+// This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110904
+#ifndef TEST_COMPILER_GCC
     static_assert((!std::is_convertible<ConstFunction, Function*>::value), "");
----------------
philnik wrote:
> Mordante wrote:
> > All versions of GCC or just 13?
> Just GCC 13
Maybe add that information in the comment and in the header too. something like
`TODO Enable again when https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110904 is fixed. The bug was introduced in GCC 13`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157060/new/

https://reviews.llvm.org/D157060