[libcxx-commits] [PATCH] D157058: [libc++] Remove generic char_traits implementation

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some nits.



================
Comment at: libcxx/docs/ReleaseNotes/18.rst:53-54
+  ``char16_t``, ``char32_t`` or a custom character type for which you
+  specialized ``std::char_traits``, your code stops stop working when we remove
+  the base template. The Standard does not mandate that a base template is
+  provided, and such a base template is bound to be incorrect for some types,
----------------



================
Comment at: libcxx/docs/ReleaseNotes/18.rst:56
+  provided, and such a base template is bound to be incorrect for some types,
+  which could currently cause unexpected behavior while going undetected.
 
----------------



================
Comment at: libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp:416
-
-  test<int>();
 }
----------------
philnik wrote:
> @Mordante Does this seem fine to you? I don't think it makes sense to test `int` here, since from the looks of it this is about testing character types.
Yes I'm fine to remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157058/new/

https://reviews.llvm.org/D157058