[libcxx-commits] [PATCH] D157364: [libc++][Modules] Generate the __std_clang_module header

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/docs/Contributing.rst:55
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
 
----------------
iana wrote:
> Mordante wrote:
> > Typically our generated files are stored in git and manually regenerated. This makes it easier to track changes.
> > 
> > The 'generated output` CI job regenerated the file and complains when a difference happens.
> Are you saying this should move to the `libcxx-generate-files` target? Or it should be a static file that we have to remember to manually regenerate when we add/remove public headers?
It should be generated by `libcxx-generate-files` and the output should be committed in the CI. Then when you forget to  regenerate the file the CI will warn you. That way the file is available in the release tarball and we are sure it's kept up-to-date.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157364/new/

https://reviews.llvm.org/D157364