[libcxx-commits] [PATCH] D157363: [libc++][Modules] Remove unnecessary `requires` from the module map

Tue Aug 8 12:34:26 PDT 2023

iana added a comment.

In D157363#4570306 <https://reviews.llvm.org/D157363#4570306>, @Mordante wrote:

> Are you sure they are not needed? In the previous version of the module map I had to add them. I see the modular build failing too. I really want to see it green.

Trying to figure out why the modular build is failing, doesn't look related but I need to check it out.

  home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-8997ed9990e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__algorithm/pstl_backends/cpu_backends/for_each.h:52:10: error: no member named 'for_each' in namespace 'std'; did you mean 'for_each'?

   52 |     std::for_each(__first, __last, __func);

     |     ~~~~~^

  home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-8997ed9990e4-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__algorithm/for_each.h:22:74: note: 'for_each' declared here

   22 | inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX20 _Function for_each(_InputIterator __first,

      |                                                                          ^

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157363/new/

https://reviews.llvm.org/D157363