[libcxx-commits] [PATCH] D157319: [libc++] Deflake the Clang Modules CI job

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 8 05:43:14 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rGd2a61db072e9: [libc++] Deflake the Clang Modules CI job (authored by ldionne).

Changed prior to commit:
  https://reviews.llvm.org/D157319?vs=547885&id=548172#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157319/new/

https://reviews.llvm.org/D157319

Files:
  libcxx/utils/libcxx/test/params.py


Index: libcxx/utils/libcxx/test/params.py
===================================================================
--- libcxx/utils/libcxx/test/params.py
+++ libcxx/utils/libcxx/test/params.py
@@ -127,6 +127,10 @@
             AddFeature("modules-build"),
             AddCompileFlag("-fmodules"),
             AddCompileFlag("-fcxx-modules"), # AppleClang disregards -fmodules entirely when compiling C++. This enables modules for C++.
+            # Note: We use a custom modules cache path to make sure that we don't reuse
+            #       the default one, which can be shared across CI builds with different
+            #       configurations.
+            AddCompileFlag(lambda cfg: f"-fmodules-cache-path={cfg.test_exec_root}/ModuleCache"),
         ]
         if enable_modules == "clang"
         else [


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157319.548172.patch
Type: text/x-patch
Size: 812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230808/5c98d880/attachment-0001.bin>


More information about the libcxx-commits mailing list