[libcxx-commits] [PATCH] D155820: [libc++] Optimize internal function in <system_error>

Mon Aug 7 12:45:12 PDT 2023

ldionne added a comment.

This basically LGTM with updated changelog and release note. I did an internal check and couldn't find anything that referenced this symbol, which seems to support the reasoning that this was never used outside of the dylib.

================
Comment at: libcxx/benchmarks/CMakeLists.txt:188
     join_view.bench.cpp
     lexicographical_compare_three_way.bench.cpp
     map.bench.cpp
----------------
Can you please also update `libcxx/lib/abi/CHANGELOG.TXT` and `libcxx/docs/ReleaseNotes/18.rst` (in the ABI affecting changes section).

Please make sure to mention the reasoning for why this removal from the ABI should not be a breaking change!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155820/new/

https://reviews.llvm.org/D155820