[libcxx-commits] [PATCH] D155598: [libc++abi] Use std::abort() instead of std::terminate() on failure to allocate

Mon Aug 7 12:31:14 PDT 2023

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D155598#4566939 <https://reviews.llvm.org/D155598#4566939>, @ldionne wrote:

> [back from OOO]
>
> I agree with @MaskRay here in terms of the "bang for the buck". I think it would be much better to actually return `nullptr` from `__cxa_demangle`, however I don't know when I'd have time to get to it given the size of that change. I filed https://github.com/llvm/llvm-project/issues/64505 to track the improvement to return `nullptr` from `__cxa_demangle`, but I'd like to move forward with this change since it already makes things somewhat better.
>
> Any objections @nickdesaulniers @philnik?

This feels more like a temporary fix, but I guess it's fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155598/new/

https://reviews.llvm.org/D155598