[libcxx-commits] [PATCH] D156907: [libc++][modules] Removes the module partitions.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

> But include after export is not allowed.

Actually, what is not allowed is "include after import" and the import contains duplicate declarations with the `#include`. Also if we `#include` the declarations in the module purview, the linkage name will change unless we wrap them in a language linkage `extern "C++"`. In another word, `#include` them in the module purview may produce ABI breakage.

> Yes modules are not installed yet since they are still experimental and I didn't have enough time to work on this part before LLVM-17.

Yeah, it doesn't matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156907/new/

https://reviews.llvm.org/D156907