[libcxx-commits] [PATCH] D157145: [libc++][PSTL] Disable `-Wpass-failed`.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 4 14:58:00 PDT 2023


var-const created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
var-const requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

PSTL contains many pragmas that request loop vectorization, which would
produce a warning when the compiler is unable to fulfill the request (if
`-Wpass-failed` is enabled). This is normal and expected in some cases,
and we don't want`-Werror` to turn that into a compilation failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157145

Files:
  libcxx/utils/libcxx/test/params.py


Index: libcxx/utils/libcxx/test/params.py
===================================================================
--- libcxx/utils/libcxx/test/params.py
+++ libcxx/utils/libcxx/test/params.py
@@ -54,6 +54,9 @@
 
     # TODO(philnik) This fails with the PSTL.
     "-Wno-unknown-pragmas",
+    # Don't fail compilation in case the compiler fails to perform the requested
+    # loop vectorization.
+    "-Wno-pass-failed",
 ]
 
 _allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157145.547367.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230804/6cc5c5c8/attachment.bin>


More information about the libcxx-commits mailing list