[libcxx-commits] [PATCH] D157060: [libc++] Fix problems with GCC 13 and switch to it in the CI

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:117-126
 
-    // Non-referencable function type
-    static_assert((!std::is_convertible<ConstFunction, Function>::value), "");
-    static_assert((!std::is_convertible<ConstFunction, Function*>::value), "");
-    static_assert((!std::is_convertible<ConstFunction, Function&>::value), "");
-    static_assert((!std::is_convertible<ConstFunction, Function&&>::value), "");
-    static_assert((!std::is_convertible<Function*, ConstFunction>::value), "");
----------------
philnik wrote:
> This code seems bogus to me and GCC disagrees with clang here. I've filed https://github.com/llvm/llvm-project/issues/64402, since I'm quite certain that the typedef above shouldn't be accepted. If the clang folks agree with me I'll also file a bug report against GCC.
Never mind. This is actually valid code and GCC probably has a bug in `__is_convertible`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157060/new/

https://reviews.llvm.org/D157060