[libcxx-commits] [PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

[Joel E. Denny via Phabricator via libcxx-commits]

jdenny added a comment.

Thanks for the additional comments from everyone.

In D154987#4508046 <https://reviews.llvm.org/D154987#4508046>, @ldionne wrote:

> It looks like there's no reliable way to test what I was trying to test, and that test isn't *that* important anyway. I'll remove it since it was broken in the first place, so just rebase your patch. Sorry for the trouble.

No worries, and thanks for the fix.  I finally got around to the rebase.

In D154987#4539229 <https://reviews.llvm.org/D154987#4539229>, @awarzynski wrote:

> In D154987#4531662 <https://reviews.llvm.org/D154987#4531662>, @jhenderson wrote:
>
>> I think it would be worth outlining in this patch why simply calling an external python script (which could actually be embedded within the file) is insufficient for the motivating case.
>
> +1

I just extended `TestingGuide.rst`.  Let me know if it's not what you are looking for.

> Also, is this change meant to replace `%python`? That would be very nice and would also help maintain consistency within our tests. Otherwise, we will have "yet another way" to run Python.

I'm not sure we can prevent every subproject from defining its own `%python` lit substitution in its test suite configuration.  I'd like to think many would eventually choose the PYTHON directive instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154987/new/

https://reviews.llvm.org/D154987