[libcxx-commits] [PATCH] D156907: [libc++][modules] Removes the module partitions.

[Aaron Siddhartha Mondal via Phabricator via libcxx-commits]

aaronmondal added a comment.

I like this change a lot. Seems like its strictly better than the previous variant. Are there any "downsides" to this change? I guess just the the single module file takes longer to build since its one gigantic file?

"Downstream-wise", the Bazel implementation will be simple to get working with this change and the improved buildtime and artifact sizes far outweigh the slight inconvenience of changing buildfiles.

No strong opinions regarding backporting. I'd expect users of such experimental technologies to live at head anyways 😅


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156907/new/

https://reviews.llvm.org/D156907