[libcxx-commits] [PATCH] D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`.

Will Hawkins via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 2 22:58:03 PDT 2023


hawkinsw marked 2 inline comments as done.
hawkinsw added a comment.

Thank you, @Mordante !



================
Comment at: libcxx/include/__ranges/stride_view.h:52
+  static constexpr bool _UseCache = !random_access_range<_View> && !common_range<_View>;
+  using _Cache = _If<_UseCache, __non_propagating_cache<reverse_iterator<iterator_t<_View>>>, __empty_cache>;
+
----------------
Yes, I realize that this is crazy! It is dead code and I will eliminate it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156924/new/

https://reviews.llvm.org/D156924



More information about the libcxx-commits mailing list