[libcxx-commits] [PATCH] D156907: [libc++][modules] Removes the module partitions.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

Thanks for your time! The numbers are very surprising and compelling to me too! It gives me more confidence for modules. And this patch LGTM and I'd like to leave the formal approval to @ldionne.

And for the topic whether or not to backport this patch to 17.x, my thought is definitely "yes, we should". On the one hand, the std modules are a very important feature at least to me and I don't want the C++ fans feel frustrated after they take some personal times to give a try and found that the std modules is slower 4.x times than the non-modules code in a hello world example. And now we have a chance to improve that. Then I can't understand why we don't do that. On the other hand, the std modules feature is still experimental, so it might not be a blocker to do some changes. Especially, we haven't released it yet. So it doesn't sound like a blocker to me too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156907/new/

https://reviews.llvm.org/D156907