[libcxx-commits] [PATCH] D156609: [libc++][print] Adds ostream overloads.

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added a comment.

Just skimmed over it. I do not know enough about `std::print` for an in-depth review, hence just a couple of typos



================
Comment at: libcxx/docs/ImplementationDefinedBehavior.rst:18
+* First it determines whether the stream's ``rdbuf()`` has an underlying
+  ``FILE*``. this is ``true`` in the following cases:
+
----------------



================
Comment at: libcxx/include/__availability:178
+    // This controls the availability of the C++23 print library,
+    // which has a dependenct on the builtin library to use the buffer
+    // types of std::cout, std::cerr, and std::clog.
----------------



================
Comment at: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/locale-specific_form.pass.cpp:22
+
+// This test the locale-specific form for these print functions:
+// template<class... Args>
----------------
There seems to be a verb missing...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156609/new/

https://reviews.llvm.org/D156609