[libcxx-commits] [PATCH] D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D156924#4555100 <https://reviews.llvm.org/D156924#4555100>, @hawkinsw wrote:

> In D156924#4555070 <https://reviews.llvm.org/D156924#4555070>, @Mordante wrote:
>
>> Thanks for working on this!
>>
>> I'm not to familiar with ranges to I leave a real review to others. I mainly glossed over the patch.
>>
>> Based on https://libcxx.llvm.org/Status/Ranges @H-G-Hristov is working on this too, @H-G-Hristov what is the status of your work?
>>
>> If you want to work on a different view nobody is working on please let us know, we can put your name on it.
>
> I am really eager to help however I can! I am a huge language geek and love open source. The past two days of coding on this little side project have been the most eye-opening C++ experience I have had since I started (mid 90s). If @H-G-Hristov wants to take over, that's great -- just assign me whatever needs to be done!
>
> Will

I think nobody is working on the C++23 range based algorithms. I found some patches for other views. Unfortunately the Phabricator search is under heavy load so I can't search. Maybe visit our Discord channel and reach out to @varconst or @philnik they are most familiar in this area. If you don't know where our Discord is, the link is at the top of https://libcxx.llvm.org/Contributing.html



================
Comment at: libcxx/include/__ranges/stride_view.h:187
+    _LIBCPP_HIDE_FROM_ABI
+    constexpr __iterator(__iterator<!_Const> __i) requires _Const && std::convertible_to<ranges::iterator_t<_View>, ranges::iterator_t<_Base>> && std::convertible_to<ranges::sentinel_t<_View>, ranges::sentinel_t<_Base>>
+      : __current_(std::move(__i.__current_)), __end_(std::move(__i.__end_)), __stride_(__i.__stride_), __missing_(__i.__missing_)
----------------
hawkinsw wrote:
> Mordante wrote:
> > This line is too long, please use clang-format to format the patch.
> Will do!!
> 
> This is actually a meta question -- I ran `clang-format` (in the `libcxx/` directory with the `.clang-format` file) and noticed that the result was nothing like what the other files looked like. I was worried that I had done something wrong. 
> 
> 
Not all files are formatted. Currently we use clang-format-17. We like new files to be formatted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156924/new/

https://reviews.llvm.org/D156924