[libcxx-commits] [PATCH] D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added subscribers: H-G-Hristov, Mordante.
Mordante added a comment.

Thanks for working on this!

I'm not to familiar with ranges to I leave a real review to others. I mainly glossed over the patch.

Based on https://libcxx.llvm.org/Status/Ranges @H-G-Hristov is working on this too, @H-G-Hristov what is the status of your work?

If you want to work on a different view nobody is working on please let us know, we can put your name on it.



================
Comment at: libcxx/include/__ranges/stride_view.h:187
+    _LIBCPP_HIDE_FROM_ABI
+    constexpr __iterator(__iterator<!_Const> __i) requires _Const && std::convertible_to<ranges::iterator_t<_View>, ranges::iterator_t<_Base>> && std::convertible_to<ranges::sentinel_t<_View>, ranges::sentinel_t<_Base>>
+      : __current_(std::move(__i.__current_)), __end_(std::move(__i.__end_)), __stride_(__i.__stride_), __missing_(__i.__missing_)
----------------
This line is too long, please use clang-format to format the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156924/new/

https://reviews.llvm.org/D156924