[libcxx-commits] [PATCH] D156585: [libc++][print] Make `<print>` tests require file system support.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const updated this revision to Diff 546243.
var-const marked 2 inline comments as done.
var-const added a comment.

Address feedback


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156585/new/

https://reviews.llvm.org/D156585

Files:
  libcxx/test/std/input.output/iostream.format/print.fun/no_file_description.pass.cpp
  libcxx/test/std/input.output/iostream.format/print.fun/print.sh.cpp
  libcxx/test/std/input.output/iostream.format/print.fun/println.sh.cpp
  libcxx/test/std/input.output/iostream.format/print.fun/vprint_nonunicode.sh.cpp
  libcxx/test/std/input.output/iostream.format/print.fun/vprint_unicode.sh.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
  libcxx/utils/generate_feature_test_macro_components.py
  libcxx/utils/libcxx/test/header_information.py


Index: libcxx/utils/libcxx/test/header_information.py
===================================================================
--- libcxx/utils/libcxx/test/header_information.py
+++ libcxx/utils/libcxx/test/header_information.py
@@ -45,7 +45,7 @@
     "locale.h": "// UNSUPPORTED: no-localization",
     "mutex": "// UNSUPPORTED: no-threads, c++03",
     "ostream": "// UNSUPPORTED: no-localization",
-    "print": "// UNSUPPORTED: availability-fp_to_chars-missing", # TODO PRINT investigate
+    "print": "// UNSUPPORTED: no-filesystem, c++03, c++11, c++14, c++17, c++20, availability-fp_to_chars-missing", # TODO PRINT investigate
     "regex": "// UNSUPPORTED: no-localization",
     "semaphore": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17",
     "shared_mutex": "// UNSUPPORTED: no-threads, c++03, c++11",
Index: libcxx/utils/generate_feature_test_macro_components.py
===================================================================
--- libcxx/utils/generate_feature_test_macro_components.py
+++ libcxx/utils/generate_feature_test_macro_components.py
@@ -1179,6 +1179,7 @@
     "locale": ["UNSUPPORTED: no-localization"],
     "mutex": ["UNSUPPORTED: no-threads"],
     "ostream": ["UNSUPPORTED: no-localization"],
+    "print": ["UNSUPPORTED: no-filesystem"],
     "regex": ["UNSUPPORTED: no-localization"],
     "semaphore": ["UNSUPPORTED: no-threads"],
     "shared_mutex": ["UNSUPPORTED: no-threads"],
Index: libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
+++ libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp
@@ -11,6 +11,8 @@
 //
 // clang-format off
 
+// UNSUPPORTED: no-filesystem
+
 // <print>
 
 // Test the feature test macros defined by <print>
Index: libcxx/test/std/input.output/iostream.format/print.fun/vprint_unicode.sh.cpp
===================================================================
--- libcxx/test/std/input.output/iostream.format/print.fun/vprint_unicode.sh.cpp
+++ libcxx/test/std/input.output/iostream.format/print.fun/vprint_unicode.sh.cpp
@@ -6,6 +6,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// UNSUPPORTED: no-filesystem
 // UNSUPPORTED: executor-has-no-bash
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
Index: libcxx/test/std/input.output/iostream.format/print.fun/vprint_nonunicode.sh.cpp
===================================================================
--- libcxx/test/std/input.output/iostream.format/print.fun/vprint_nonunicode.sh.cpp
+++ libcxx/test/std/input.output/iostream.format/print.fun/vprint_nonunicode.sh.cpp
@@ -6,6 +6,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// UNSUPPORTED: no-filesystem
 // UNSUPPORTED: executor-has-no-bash
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
Index: libcxx/test/std/input.output/iostream.format/print.fun/println.sh.cpp
===================================================================
--- libcxx/test/std/input.output/iostream.format/print.fun/println.sh.cpp
+++ libcxx/test/std/input.output/iostream.format/print.fun/println.sh.cpp
@@ -6,6 +6,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// UNSUPPORTED: no-filesystem
 // UNSUPPORTED: executor-has-no-bash
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
Index: libcxx/test/std/input.output/iostream.format/print.fun/print.sh.cpp
===================================================================
--- libcxx/test/std/input.output/iostream.format/print.fun/print.sh.cpp
+++ libcxx/test/std/input.output/iostream.format/print.fun/print.sh.cpp
@@ -6,6 +6,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// UNSUPPORTED: no-filesystem
 // UNSUPPORTED: executor-has-no-bash
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
Index: libcxx/test/std/input.output/iostream.format/print.fun/no_file_description.pass.cpp
===================================================================
--- libcxx/test/std/input.output/iostream.format/print.fun/no_file_description.pass.cpp
+++ libcxx/test/std/input.output/iostream.format/print.fun/no_file_description.pass.cpp
@@ -1,4 +1,5 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// UNSUPPORTED: no-filesystem
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
 // XFAIL: msvc, target={{.+}}-windows-gnu


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156585.546243.patch
Type: text/x-patch
Size: 4742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230801/c8c2849a/attachment.bin>