[libcxx-commits] [PATCH] D148641: [libc++] Add C++20 stringstream::view()

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D148641#4306046 <https://reviews.llvm.org/D148641#4306046>, @pfusik wrote:

> Is the failed build my fault?

No unfortunately these 3 CI runners have issues at the moment.



================
Comment at: libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/view.pass.cpp:23
+
+static std::string_view get_view(const std::istringstream& ss) noexcept { return ss.view(); }
+
----------------
pfusik wrote:
> Mordante wrote:
> > Why did you add this helper function?
> To test `const noexcept`. I did not know `static_assert(noexcept(...))`.
I think that is quite subtile. I would prefer the making the object const explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148641/new/

https://reviews.llvm.org/D148641