[libcxx-commits] [PATCH] D132268: [libc++][spaceship] Implement `operator<=>` for `vector`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 30 06:11:15 PDT 2023


Mordante added inline comments.


================
Comment at: libcxx/docs/Status/SpaceshipProjects.csv:43
+| `[vector.syn] <https://wg21.link/vector.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| `vector <https://reviews.llvm.org/D132268>`_,[expos.only.func],"| Adrian Vogelsgesang
+| Hristo Hristov",|Complete|
 | `[associative.map.syn] <https://wg21.link/associative.map.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),"| `map <https://reviews.llvm.org/D145976>`_
----------------
Did you validate this output looks good?


================
Comment at: libcxx/test/std/containers/sequences/vector.bool/compare.three_way.pass.cpp:55
+    std::vector<bool> t1{true};
+    std::vector<bool> t2{true, true};
+    assert(testOrder(t1, t2, std::strong_ordering::less));
----------------
lx and tx are identical.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132268/new/

https://reviews.llvm.org/D132268



More information about the libcxx-commits mailing list