[libcxx-commits] [PATCH] D148641: [libc++] Add C++20 stringstream::view()

[Piotr Fusik via Phabricator via libcxx-commits]

pfusik marked an inline comment as done.
pfusik added a comment.

There's more in the paper. I'd be happy to implement these in subsequent commits.



================
Comment at: libcxx/include/sstream:492
+basic_string_view<_CharT, _Traits>
+basic_stringbuf<_CharT, _Traits, _Allocator>::view() const noexcept
+{
----------------
Mordante wrote:
> Please format the new code with clang-format so it matches our "normal" style. 
How do I do that?


================
Comment at: libcxx/include/sstream:498
+            __hm_ = this->pptr();
+        return basic_string_view<_CharT, _Traits>(this->pbase(), __hm_ - this->pbase());
+    }
----------------
philnik wrote:
> Generally, we don't spell out the this pointer if not required.
Ok. Here it is required (accessing class template base member).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148641/new/

https://reviews.llvm.org/D148641