[libcxx-commits] [PATCH] D147741: [libc++, std::vector] call the optimized version of __uninitialized_allocator_copy for trivial types

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__memory/uninitialized_algorithms.h:607
+  } else {
+    return std::copy(__first1, __last1, const_cast<_RawType*>(__first2));
+  }
----------------
hiraditya wrote:
> Mordante wrote:
> > LLVM style is not `else` after a `return`, here and other places in this patch. Note the `if constexpr` does get the `else` to avoid generating unneeded code by the compiler.
> This code is directly copied from the function above. Not sure what is the guidance for libcxx is, cc: @ldionne 
We have more code that does not conform to our policy, but for new code we use our policy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147741/new/

https://reviews.llvm.org/D147741