[libcxx-commits] [PATCH] D147741: [libc++, std::vector] call the optimized version of __uninitialized_allocator_copy for trivial types

[Aditya Kumar via Phabricator via libcxx-commits]

hiraditya added a comment.

> Looking at the benchmark this patch has a negative effect on the average times. Can you explain why that happens?

Oh it seems i reversed the base vs. diff. I'll fix the numbers after running again.

> Did you look at the generated assembly after your changes?

Yes, the vector::copy operation (BM_CopyConstruct/vector_int) is just gone for after this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147741/new/

https://reviews.llvm.org/D147741