[libcxx-commits] [PATCH] D148641: [libc++] Add C++20 stringstream::view()

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/sstream:36
     basic_stringbuf(basic_stringbuf&& rhs);
 
     // [stringbuf.assign] Assign and swap:
----------------
Please update the correct status paper in `libcxx/docs/Status/`.


================
Comment at: libcxx/include/sstream:259
     void str(const string_type& __s);
+    basic_string_view<char_type, traits_type> view() const noexcept; // C++20
 
----------------
Throughout


================
Comment at: libcxx/include/sstream:498
+            __hm_ = this->pptr();
+        return basic_string_view<_CharT, _Traits>(this->pbase(), __hm_ - this->pbase());
+    }
----------------
Generally, we don't spell out the this pointer if not required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148641/new/

https://reviews.llvm.org/D148641