[libcxx-commits] [PATCH] D149313: [libc++] Use __is_convertible built-in when available

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 26 17:45:39 PDT 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % comment with a green CI.



================
Comment at: libcxx/include/__type_traits/is_convertible.h:27
 
-#if __has_builtin(__is_convertible_to) && !defined(_LIBCPP_USE_IS_CONVERTIBLE_FALLBACK)
+#if __has_builtin(__is_convertible) && !defined(_LIBCPP_USE_IS_CONVERTIBLE_FALLBACK)
+
----------------
Please add a `//TODO: Remove the #else branch once GCC 13 is used in the CI`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149313/new/

https://reviews.llvm.org/D149313



More information about the libcxx-commits mailing list