[libcxx-commits] [PATCH] D143914: [libc++] Clean up pair's constructors and assignment operators

[Jordan Rupprecht via Phabricator via libcxx-commits]

rupprecht added a comment.

In D143914#4292303 <https://reviews.llvm.org/D143914#4292303>, @ldionne wrote:

> @rupprecht I'd like to land this within the next few days. If you're able to confirm that this doesn't cause as many issues for you anymore, that would be great. Otherwise, i'll land this without your confirmation -- I am fairly confident this new patch should solve the vast majority of issues you were seeing.

Sorry, I've been out for a few days. Indeed, the impact seems much smaller.

The one breakage I found so far is:

  std::vector<std::pair<int, Foo>> foo_pairs;
  for (std::pair<int, Foo&> foo : foo_pairs) {...}

I expect not many breakages, so I'm fine with this landing. Thanks for checking in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143914/new/

https://reviews.llvm.org/D143914