[libcxx-commits] [PATCH] D148324: [libcxx] [test] Prepend to PATH instead of overriding it

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm not sure I follow.

> This had the unfortunate side effect of making other tools available in PATH during the runtime of the tests

Shouldn't it be the other way around, i.e. shouldn't it make *only* the things in `%{lib}` available, which is less than if you prepend `%{lib}` to the rest of the `PATH`? This leads me to wonder whether we instead might want to acknowledge that this is only used to pass a dyld-library-path-kind-of-variable instead of trying to make it general in purpose. After all, you do use `os.pathsep` in there so it's pretty clear that this can only be used to set some sort of `$PATH`-like variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148324/new/

https://reviews.llvm.org/D148324