[libcxx-commits] [PATCH] D145807: [libcxx] [test] Print the failing commands in Configuration{Compilation, Runtime}Error

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

That's a nice improvement, thanks! I remember making a similar change locally to debug something, that should have been a hint that this was useful :-)



================
Comment at: libcxx/utils/libcxx/test/dsl.py:233
     if exitCode != 0:
      raise ConfigurationRuntimeError()
     return out
----------------
We can do better here. Let's do something like:

```
raise ConfigurationRuntimeError("Failed to run command: {}\nstderr is:\n{}", ...)
```


================
Comment at: libcxx/utils/libcxx/test/dsl.py:288
     if exitCode != 0:
       raise ConfigurationCompilationError("Failed to retrieve compiler macros, stderr is:\n{}".format(err))
     parsedMacros = dict()
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145807/new/

https://reviews.llvm.org/D145807