[libcxx-commits] [PATCH] D141888: [libc++][PSTL] Implement <execution> contents

[Louis Dionne via Phabricator via libcxx-commits]

philnik created this revision.
philnik added a reviewer: ldionne.
Herald added a project: All.
philnik updated this revision to Diff 492371.
philnik added a comment.
philnik updated this revision to Diff 492449.
philnik updated this revision to Diff 492497.
philnik updated this revision to Diff 495184.
philnik updated this revision to Diff 500198.
philnik updated this revision to Diff 500206.
philnik updated this revision to Diff 500644.
philnik updated this revision to Diff 500646.
Herald added a subscriber: arichardson.
philnik updated this revision to Diff 500762.
philnik updated this revision to Diff 516908.
philnik updated this revision to Diff 516975.
philnik marked 2 inline comments as done.
ldionne published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Rebased


philnik added a comment.

Try to fix CI


philnik added a comment.

Try to fix CI


philnik added a comment.

Try to fix CI


philnik added a comment.

Rebased


philnik added a comment.

Rebased


philnik added a comment.

Try to fix CI


philnik added a comment.

Update format ignorelist


philnik added a comment.

Try to fix CI


philnik added a comment.

Rebased


philnik added a comment.

Address comments



================
Comment at: libcxx/test/libcxx/utilities/expol/policies.compile.pass.cpp:8
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14
----------------
Please add a synopsis for what you're testing here.


================
Comment at: libcxx/test/std/utilities/expol/is_execution_policy.compile.pass.cpp:8
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14
----------------
Same, synopsis. It allows us to know precisely what is being tested in a test. In this case it's not too hard to guess, but often there are multiple function overloads or different behaviors in different standard versions, so it's useful to keep that synopsis.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141888

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__pstl_execution
  libcxx/include/execution
  libcxx/include/pstl/internal/glue_execution_defs.h
  libcxx/test/libcxx/utilities/expol/policies.compile.pass.cpp
  libcxx/test/std/utilities/expol/is_execution_policy.compile.pass.cpp
  libcxx/test/std/utilities/expol/policies.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141888.516975.patch
Type: text/x-patch
Size: 11900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230426/912ffbd7/attachment-0001.bin>