[libcxx-commits] [PATCH] D145589: [libc++] Make std::allocator_arg and friends conforming in C++17

[Hans Wennborg via Phabricator via libcxx-commits]

hans added a comment.

We're seeing build failures in Chromium: https://crbug.com/1440126
It's not clear why it's only in some builds, but the linker complains about duplicate definitions of `placeholders::__ph<1>`: both from libc++'s `bind.cpp` and from some Chromium file which presumably includes `__functional/bind.h`.

The commit message says "now that we don't define strong definitions of those variables in the shared library anymore." but it seems we do have strong definitions for these in bind.cpp still, or am I missing something?

It looks like D145587 <https://reviews.llvm.org/D145587> removed the strong definitions of `allocator_arg` etc. but it did not touch the placeholder variables. Was that intentional, or is the fix here to just remove bind.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145589/new/

https://reviews.llvm.org/D145589